Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nuraft dependency to intake new_joiner #104

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Update nuraft dependency to intake new_joiner #104

merged 2 commits into from
Oct 17, 2024
+170 −3

Conversation

xiaoxichen
Copy link
Contributor

szmyd
szmyd reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@szmyd szmyd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the old patch not apply correctly anymore? 😕

Also, need to update the conan export in build_dependencies.yml flow.

@xiaoxichen
change build_dependency
238b2f5 
Signed-off-by: Xiaoxi Chen <[email protected]>
@xiaoxichen
Copy link
Contributor Author

Did the old patch not apply correctly anymore? 😕
Yeah unfortunately they channged a bit on makefile, 2 out of the 5 changes are missed the targets :(

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.75%. Comparing base (0262682) to head (238b2f5).
Report is 41 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   71.47%   73.75%   +2.28%     
==========================================
  Files          21       20       -1     
  Lines         887      865      -22     
  Branches      103       98       -5     
==========================================
+ Hits          634      638       +4     
+ Misses        188      161      -27     
- Partials       65       66       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

szmyd
szmyd approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@szmyd szmyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xiaoxichen xiaoxichen merged commit 06b329b into eBay:main Oct 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmyd szmyd szmyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoxichen @codecov-commenter @szmyd